>>> On 17.07.15 at 09:26, <shuai.r...@intel.com> wrote: > @@ -247,8 +250,7 @@ static void xc_cpuid_config_xsave( > regs[1] = 512 + 64; /* FP/SSE + XSAVE.HEADER */ > break; > case 1: /* leaf 1 */ > - regs[0] &= XSAVEOPT; > - regs[1] = regs[2] = regs[3] = 0;
This deletion as well as ... > + regs[0] &= (XSAVEOPT | XSAVEC | XGETBV1 | XSAVES); > break; > case 2 ... 63: /* sub-leaves */ > if ( !(xfeature_mask & (1ULL << input[1])) ) > @@ -256,8 +258,6 @@ static void xc_cpuid_config_xsave( > regs[0] = regs[1] = regs[2] = regs[3] = 0; > break; > } > - /* Don't touch EAX, EBX. Also cleanup ECX and EDX */ > - regs[2] = regs[3] = 0; ... this one need explaining in the description. And in this latter case the comment should probably be retained/amended if the code deletion is really intended/warranted. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
