Ian,

Thanks for your effort.

A tiny change may be needed but I don't block this.

+libxl__xc_device_get_rdm(libxl__gc *gc,
+                         uint32_t flag,

Since now we are sitting on xc_reserved_device_memory_map(, flags, xxx), s/flag/flags may be better.

+                         uint16_t seg,
+                         uint8_t bus,
+                         uint8_t devfn,
+                         unsigned int *nr_entries,
+                         struct xen_reserved_device_memory **xrdm)
+{

[snip]

+    r = xc_reserved_device_memory_map(CTX->xch, flag, seg, bus, devfn,

Ditto.

+                                      NULL, nr_entries);
+    assert(r <= 0);
+    /* "0" means we have no any rdm entry. */
+    if (!r) goto out;
+
+    if (errno != ENOBUFS) {
+        rc = ERROR_FAIL;
+        goto out;
+    }
+
+    GCNEW_ARRAY(*xrdm, *nr_entries);
+    r = xc_reserved_device_memory_map(CTX->xch, flag, seg, bus, devfn,

Ditto.

Thanks
Tiejun

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Reply via email to