On Mon, 2015-08-03 at 16:56 +0100, Andrew Cooper wrote: > Previously, in the case of an error causing a call to > libxl__conversion_helper_abort() on a stream without legacy conversion, > libxl would fall over a NULL pointer because chs->ao was not set up. > > Arrange for all ->ao's to be set up at _init() time, by having each > _init() function assert that their caller has done the right thing. > While doing so, introduce a previously-missing save_helper_init() in > stream_read_init(). > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > CC: Ian Campbell <ian.campb...@citrix.com> > CC: Ian Jackson <ian.jack...@eu.citrix.com> > CC: Wei Liu <wei.l...@citrix.com> > > v2: Make sure ->ao is always valid
I believe this + the extra comment in libxl__conversion_helper_state addresses Ian J's feedback from the previous round, so: Acked-by: Ian Campbell <ian.campb...@citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
