El 07/08/15 a les 18.36, Andrew Cooper ha escrit: > On 07/08/15 11:18, Roger Pau Monne wrote: >> @@ -1336,7 +1343,8 @@ static int meminit_hvm(struct xc_dom_image *dom) >> * tot_pages will be target_pages - VGA_HOLE_SIZE after >> * this call. >> */ >> - rc = xc_domain_set_pod_target(xch, domid, target_pages - >> VGA_HOLE_SIZE, >> + rc = xc_domain_set_pod_target(xch, domid, target_pages - >> + dom->emulation ? VGA_HOLE_SIZE : 0, >> NULL, NULL, NULL); > > This might be more cleanly expressed as having d->vga_hole_size which is > either VGA_HOLE_SIZE or 0, depending on dom->emulation.
I'm afraid I don't understand this comment. What's "d" in the phrase above? I cannot see any local variable or argument called "d" in the context of meminit_hvm. Or do you mean that the dom->emulation flag should be split into dom->disable_ioreqs and dom->vga_hole_size? Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
