>>> On 06.09.15 at 08:07, <feng...@intel.com> wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Friday, September 04, 2015 10:23 PM >> >>> On 25.08.15 at 03:57, <feng...@intel.com> wrote: >> > --- >> > v6: >> > - Fix a typo >> > >> > v5: >> > - Change back the parameters of __cmpxchg16b() to __uint128_t * >> > - Remove pointless cast for 'ptr' >> > - Remove pointless parentheses >> > - Use A constraint for the output >> >> There are a few comments I had on v4 which neither have been >> addressed verbally nor have got incorporated into the patch. See >> http://lists.xenproject.org/archives/html/xen-devel/2015-07/msg04694.html > > Do you mean I missed the following part in the above link? > > " But I think now I recall that it may have been me asking for using > void pointers here: That way one can pass pointers to other types. > But then you would better cast to void * here, and have the inline > function have properly typed pointers. And it should go without > saying that if you cast (or implicitly convert to void), you should > validate that what your caller handed you is at least the size of a > __uint128_t (and for "ptr" perhaps also, as I think Andrew already > pointed out, that it is suitably aligned). "
And for the record - I was referring to more than just that (in particular the need for a memory clobber). Please, prior to asking back, check what parts of the comments you actually did take care of, and deal with _everything_ you didn't. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
