On 27/10/15 15:39, Julien Grall wrote: > Hi all, > > I wrote this patch series after noticing that one of my series [1] was > shadowing a variable and GCC didn't warn it. > > So I've turned on -Wshadow and look at if there is other places abusing > of shadow variable in Xen. > > This series is not complete and only contain the more simple changes. > > I'd like to have some input to know whether turning on -Wshadow would be > sensible in the future. > > Regards,
All 6 patches Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> As for the -Wshadow default, that is more problematic. There are several quite buggy verisons of GCC wrt shadowing, so I don't think it is sensible to enable unilaterally. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
