On Tue, Nov 17, 2015 at 03:34:30PM +0000, David Vrabel wrote: > On 17/11/15 15:08, Wei Liu wrote: > > There are mixed usage of libxl__sprintf(gc) and GCSPRINTF. Convert all > > libxl__sprintf to GCSPRINTF. > > This looks like pointless churn /and/ GCSPRINTF is /less/ readable than > libxl__sprintf(gc,...) because the reader now has to also look up what > GCSPRINTF does. >
The goal is to make things consistent across libxl code base. Currently there are 400+ GCSPRINTF vs 240+ libxl__sprintf, which is causing confusion for contributors. If you think libxl__sprintf is clear you can submit patch to turn that 400+ GCSPRINTF to libxl__sprintf. Wei. > David > > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
