On Wed, 2015-12-16 at 10:24 +0100, Juergen Gross wrote:
> Set the SIF_VIRT_P2M_4TOOLS flag for pv-domUs in the domain builder
> to indicate the Xen tools have full support for the virtual mapped
> linear p2m list.
>
> This will enable pv-domUs to drop support of the 3 level p2m tree
> and use the linear list only. Without setting this flag some kernels
> might limit themselves to 512 GB memory size in order not to break
> migration.
>
> Signed-off-by: Juergen Gross <jgr...@suse.com>
> Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com>
Acked-by: Ian Campbell <ian.campb...@citrix.com>
I would have applied all 4 on the basis of Andy's other Reviewed-by to the
patches purely touching migration v2 files, except for this on 32-bit:
xc_sr_save_x86_pv.c:328:9: error: format ‘%lx’ expects argument of type ‘long
unsigned int’, but argument 4 has type ‘uint64_t’ [-Werror=format=]
ERROR("Bad p2m_cr3 value %#lx", p2m_cr3);
^
xc_sr_save_x86_pv.c:350:13: error: format ‘%lx’ expects argument of type ‘long
unsigned int’, but argument 4 has type ‘xen_vaddr_t’ [-Werror=format=]
ERROR("Bad virtual p2m address range %#lx-%#lx",
^
xc_sr_save_x86_pv.c:350:13: error: format ‘%lx’ expects argument of type ‘long
unsigned int’, but argument 5 has type ‘xen_vaddr_t’ [-Werror=format=]
xc_sr_save_x86_pv.c:363:13: error: format ‘%lx’ expects argument of type ‘long
unsigned int’, but argument 4 has type ‘xen_vaddr_t’ [-Werror=format=]
ERROR("Bad virtual p2m address range %#lx-%#lx",
^
xc_sr_save_x86_pv.c:363:13: error: format ‘%lx’ expects argument of type ‘long
unsigned int’, but argument 5 has type ‘xen_vaddr_t’ [-Werror=format=]
xc_sr_save_x86_pv.c:370:5: error: format ‘%lx’ expects argument of type ‘long
unsigned int’, but argument 6 has type ‘xen_vaddr_t’ [-Werror=format=]
DPRINTF("p2m list from %#lx to %#lx, root at %#lx", p2m_vaddr, p2m_end,
^
xc_sr_save_x86_pv.c:370:5: error: format ‘%lx’ expects argument of type ‘long
unsigned int’, but argument 7 has type ‘xen_vaddr_t’ [-Werror=format=]
xc_sr_save_x86_pv.c:413:17: error: format ‘%lx’ expects argument of type ‘long
unsigned int’, but argument 5 has type ‘long long unsigned int’
[-Werror=format=]
ERROR("Bad mfn %#lx during page table walk for vaddr %#lx at
level %d of p2m list",
^
cc1: all warnings being treated as errors
/local/scratch/ianc/devel/committer-i686.git/tools/libxc/../../tools/Rules.mk:163:
recipe for target 'xc_sr_save_x86_pv.o' failed
> @@ -1,5 +1,5 @@
> % Migration
> -% Revision 1
> +% Revision 2
Well done on this, I predict it will get forgotten more often than not ;-)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
