>>> On 23.01.16 at 10:19, <zhaoshengl...@huawei.com> wrote:
> From: Shannon Zhao <shannon.z...@linaro.org>
>
> When MADT is parsed, print GIC information to make the boot log look
> pretty.
>
> Signed-off-by: Hanjun Guo <hanjun....@linaro.org>
> Signed-off-by: Tomasz Nowicki <tomasz.nowi...@linaro.org>
> Signed-off-by: Shannon Zhao <shannon.z...@linaro.org>
Is this the equivalent of a Linux side commit? If so please name it.
If not, ...
> --- a/xen/drivers/acpi/tables.c
> +++ b/xen/drivers/acpi/tables.c
> @@ -189,6 +189,28 @@ void __init acpi_table_print_madt_entry(struct
> acpi_subtable_header *header)
> }
> break;
>
> + case ACPI_MADT_TYPE_GENERIC_INTERRUPT:
> + {
> + struct acpi_madt_generic_interrupt *p =
> + (struct acpi_madt_generic_interrupt *)header;
... no matter that other cases here have been coded in a similarly
bad manner, please do better than them and use container_of()
instead of a cast here. (Cleaning up the others is [fairly low] on my
todo list.)
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
