> From: Jan Beulich
> Sent: Tuesday, January 26, 2016 8:57 PM
> To: Chang Jianzhong
> Cc: andrew.coop...@citrix.com; k...@xen.org; xen-devel@lists.xen.org
> Subject: Re: [Xen-devel] [PATCH] xen vtd : set msi guest_masked 0 by default
> 
> >>> On 26.01.16 at 02:34, <chang...@gmail.com> wrote:
> > There are some problems when msi guest_masked is set to 1 by default.
> > When guest os is windows 2008 r2 server,
> > the device(eg X540-AT2 vf) is not initialized correctly.
> > Host will always receive message like this :"VF Reset msg received from vf".
> > Guest has network connectivity issues,
> > and can not correctly receive/send the packet.
> > So, guest_masked is set to 0 by default.
> 
> You describe a problem and half of your change, but there's no
> connection between the two: What is actually wrong with current
> behavior (matching the hardware's - MSI-X mask bits are set when
> coming out of reset).
> 

Agree. Jianzhong, could you elaborate how mask bit is related to
the error message above? Also instead of changing the behavior
completely, you need consider there must be a reason for 
guest_masked set to 1 originally. So when you fix one issue please
pay attention to not break other scenarios.

Thanks
Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Reply via email to