Ian Campbell writes ("Re: [Xen-devel] [PATCH] tools: remove xenpmd"):
> On Wed, 2016-02-17 at 12:05 -0500, Konrad Rzeszutek Wilk wrote:
> > On Wed, Feb 17, 2016 at 02:41:14PM +0000, Ian Campbell wrote:
> > > It has four instances of the same CID 1198719 (strncpy(..., 32) into a
> > > 32-byte buffer).
> > >
> > > However ever since it was checked in in 2008 it has contained a
> > > /tmp instead of the real ones in /proc. I therefore conclude that it
> > > has not ever been used in its current form in the last 8 years and
> > > might as well therefore be deleted. The code remains in the git
> > > history should anyone one to reanimate it.
> > >
> > > Searching online shows no references to the use of this tool.
> > >
> > > Signed-off-by: Ian Campbell <ian.campb...@citrix.com>
> >
> > Acked-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com>
> >
> > .. Can I commit this in now :-)
>
> I think formally it probably needs an Ack from Wei or Ian?
I think it probably does, and:
Acked-by: Ian Jackson <ian.jack...@eu.citrix.com>
But:
> I usually give this sort of thing (removals etc) a little longer than
> normal to give more of a chance for objections, although the counter to
> that is that once this is committed it could just as easily be reverted the
> next day as in 6 months time if someone turns up with a good reason it
> shouldn't have been nuked.
Deleting it right away seems a bit rude. Maybe someone is using it
with the #define sorted out. So if nothing intervenes I guess we
should commit this late next week ?
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
