Wei Liu writes ("[PATCH for-4.7] libxl: set XEN_QEMU_CONSOLE_LIMIT for QEMU"): > XSA-180 provides a patch to QEMU to bodge QEMU logging issue. We > explicitly set the limit in libxl for 4.7. ... > + unsigned long limit = 0; > + const char *s = getenv("XEN_QEMU_CONSOLE_LIMIT"); > + > + limit = s ? strtoul(s,0,0) : 1*1024*1024; > + flexarray_append_pair(dm_envs, "XEN_QEMU_CONSOLE_LIMIT", > + GCSPRINTF("%lu", limit));
This is rather more complex than it needs to be. What would be wrong with if (getenv("XEN_QEMU_CONSOLE_LIMIT")) return; flexarray_append_pair(dm_envs, "XEN_QEMU_CONSOLE_LIMIT", "1048576"); ? But I guess I don't object enough to care, so Acked-by: Ian Jackson <ian.jack...@eu.citrix.com> > + flexarray_t *dm_args, *dm_envs; > + char **args, **envs; All these parts are a bit of a palaver but I don't see a better way. Thanks for doing this work! Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel