>>> On 06.06.16 at 15:09, <boris.ostrov...@oracle.com> wrote: > On 06/06/2016 04:47 AM, Jan Beulich wrote: >> It's identical to bar_init() now. >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> >> --- >> I'm sorry for this 3/2 - I only now noticed that this additional >> simplification is now possible. > > I wonder whether we should also move content of read_dev_bar() into > bar_init(). Especially given that it's not really reading a BAR but > rather initializing the stashed value.
I had considered that too, but then thought the splitting out of that logic could as well stay. If we were to do that, I'd in fact prefer merging patches 2 and 3 (plus this additional adjustment). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel