On Mon, 2016-06-20 at 13:59 +0100, Andrew Cooper wrote:
> On 15/06/16 11:27, Jan Beulich wrote:
> > Matching Linux commit 03b9730b76 ("x86/asm/tsc: Add rdtsc_ordered()
> > and
> > use it in trivial call sites") and earlier ones it builds upon,
> > let's
> > make sure timing loops don't have their rdtsc()-s re-ordered, as
> > that
> > would harm precision of the result (values were observed to be
> > several
> > hundred clocks off without this adjustment).
> >
> > Signed-off-by: Jan Beulich <[email protected]>
>
> Reviewed-by: Andrew Cooper <[email protected]>
>
FWIW:Reviewed-by: Dario Faggioli <[email protected]> Tested-by: Dario Faggioli <[email protected]> (or Reviewed-and-Tested-by: as you wish :-)). FTR, during my own investigation, before raising the issue on the mailing list, I also came to the conclusion that we'd need something like this. I even try doing something like this (in a much more hacky way), and had the feeling that it was making a difference but, of course, alone, without all the other issues that Jan found and fixed in this series, it wasn't enough. Thanks and regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list [email protected] https://lists.xen.org/xen-devel
