>>> On 05.07.16 at 21:05, <boris.ostrov...@oracle.com> wrote: > --- a/xen/arch/x86/hvm/vlapic.c > +++ b/xen/arch/x86/hvm/vlapic.c > @@ -1115,7 +1115,12 @@ static int __vlapic_accept_pic_intr(struct vcpu *v) > struct domain *d = v->domain; > struct vlapic *vlapic = vcpu_vlapic(v); > uint32_t lvt0 = vlapic_get_reg(vlapic, APIC_LVT0); > - union vioapic_redir_entry redir0 = domain_vioapic(d)->redirtbl[0]; > + union vioapic_redir_entry redir0; > + > + if ( !has_vioapic(d) || !has_vpic(d) )
The has_vpic() part should really be an ASSERT(), as both callers already do that check afaics. With that adjusted Reviewed-by: Jan Beulich <jbeul...@suse.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
