>>> On 19.08.16 at 02:04, <car...@cardoe.com> wrote: > On 8/18/16 6:44 PM, Derek Straka wrote: >> Allows for the conditional inclusion of tboot related functionality >> via Kconfig >> >> The default configuration for the new CONFIG_TBOOT option is 'y', so the >> behavior out of the box remains unchanged. The addition of the option > allows >> advanced users to disable system behaviors associated with tboot at compile >> time rather than relying on the run-time detection and configuration. >> >> The CONFIG_CRYPTO option is 'n' by default and selected by the individual > users >> that require the functionality. Currently, the only user is tboot. >> >> Signed-off-by: Derek Straka <de...@asterius.io> >> --- > > Reviewed-by: Doug Goldstein <car...@cardoe.com> > > >> >> +config CRYPTO >> + bool >> + default n >> + > > If a v3 happens (or the committer wants to change it) this can be > "def_bool n".
This isn't just a "can be", nor should it become def_bool. Defaults for select only options should be omitted altogether, so that when a prompt gets added to them and nothing has previously selected it, the user will be presented with a prompt instead of the already recorded default of "no" getting used. But yes, no v3 is needed, this line can easily be dropped while committing. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel