>>> On 30.08.16 at 14:01, <wei.l...@citrix.com> wrote: > Signed-off-by: Wei Liu <wei.l...@citrix.com>
Acked-by: Jan Beulich <jbeul...@suse.com> with one adjustment (see below). > Cc: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> > Cc: Stefano Stabellini <sstabell...@kernel.org> > Cc: Tim Deegan <t...@xen.org> > Cc: Doug Goldstein <car...@cardoe.com> > > Would like to have it default to DEBUG, but we also need to check > compiler to be gcc. I couldn't figure out how to check compiler to be > gcc in Kconfig. Actually I don't think defaulting to DEBUG would have been a good idea. Why would you want everyone to carry that extra baggage regardless of whether they actually mean to make use of it? And anyway, conversion to Kconfig should retain current behavior, which clearly was ... > --- a/Config.mk > +++ b/Config.mk > @@ -20,9 +20,6 @@ or = $(if $(strip $(1)),$(1),$(if $(strip > $(2)),$(2),$(if $(strip $(3)),$( > debug ?= y > debug_symbols ?= $(debug) > > -# Test coverage support > -coverage ?= n ... off by default. > --- a/xen/Kconfig.debug > +++ b/xen/Kconfig.debug > @@ -13,6 +13,11 @@ config DEBUG > > if DEBUG || EXPERT = "y" > > +config GCOV > + bool "Gcov Support" > + ---help--- > + Enable gcov (a test coverage program in GCC) support. > + > config CRASH_DEBUG > bool "Crash Debugging Support" > depends on X86 I now see that someone prior to you already managed to break the alphabetical ordering (DEVICE_TREE_DEBUG got added to the end), but please don't introduce further issues like this. The only exception here are entries which have dependencies on others in this same section (like PERF_ARRAYS depends on PERF_COUNTERS). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
