On 08/09/16 14:43, Jan Beulich wrote:
> @@ -2861,21 +2860,20 @@ x86_emulate(
> dst.val = src.val;
> break;
>
> - case 0x8c: /* mov Sreg,r/m */ {
> - struct segment_register reg;
> - enum x86_segment seg = decode_segment(modrm_reg);
> + case 0x8c: /* mov Sreg,r/m */
> + seg = decode_segment(modrm_reg);
> generate_exception_if(seg == decode_segment_failed, EXC_UD, -1);
> + store_seg:
store_seg is easy to confuse with load_seg. How about read_selector
instead?
It also occurs to me that you might have an easier time with both this
patch and patch 1 if you reversed their order. Either way, Reviewed-by:
Andrew Cooper <andrew.coop...@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
