On 01/12/16 10:18, Jan Beulich wrote:
>>>> On 30.11.16 at 14:50, <andrew.coop...@citrix.com> wrote:
>> --- a/xen/arch/x86/x86_emulate/x86_emulate.c
>> +++ b/xen/arch/x86/x86_emulate/x86_emulate.c
>> @@ -2656,6 +2656,8 @@ x86_emulate(
>> &dst.val, op_bytes, ctxt, ops)) != 0 ||
>> (rc = load_seg(src.val, dst.val, 0, NULL, ctxt, ops)) != 0 )
>> goto done;
>> + if ( src.val == x86_seg_ss )
>> + ctxt->retire.mov_ss = 1;
> While I don't mind it being done here (i.e. it can have my R-b as is),
> wouldn't it be even better to put this into load_seg() itself?
That would cause the mov_ss flag to be incorrectly set for `lss`.
Xen-devel mailing list