On 14/12/16 15:13, Jan Beulich wrote:
>>>> On 14.12.16 at 15:26, <andrew.coop...@citrix.com> wrote:
>> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
>> ---
>> CC: Jan Beulich <jbeul...@suse.com>
>> CC: Tim Deegan <t...@xen.org>
>> CC: George Dunlap <george.dun...@eu.citrix.com>
>> CC: Konrad Rzeszutek Wilk <konrad.w...@oracle.com>
>> CC: Stefano Stabellini <sstabell...@kernel.org>
>> CC: Julien Grall <julien.gr...@arm.com>
>>
>> The one use of paging_mark_dirty() in common/tmem shows that TMEM currently
>> wont compile for ARM.
> I don't understand: It builds prior to this change, so why would it
> stop building afterwards? Without this remark I'd have given my
> R-b ...
Oh. cli_{get,put}_page() are stubbed to ASSERT(0) on ARM, which
restricts the paging_mark_dirty() call to !ARM.
The history is weird here. The last change here was you taking out the
__ia64__ code.
I can't work out why they should be stubbed separately; there is nothing
overly x86-specific in them.
Konrad: Any ideas?
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
