> -----Original Message----- > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Jan > Beulich > Sent: 15 December 2016 16:23 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: Andrew Cooper <andrew.coop...@citrix.com>; Daniel De Graaf > <dgde...@tycho.nsa.gov>; Wei Liu <wei.l...@citrix.com>; Ian Jackson > <ian.jack...@citrix.com>; xen-de...@lists.xenproject.org > Subject: Re: [Xen-devel] [PATCH v2 7/8] dm_op: convert > HVMOP_inject_trap and HVMOP_inject_msi > > >>> On 06.12.16 at 14:46, <paul.durr...@citrix.com> wrote: > > +struct xen_dm_op_inject_trap { > > + /* IN - index of vCPU */ > > + uint32_t vcpuid; > > + /* IN - interrupt vector */ > > + uint8_t vector; > > + /* IN - trap type (DMOP_TRAP_* ) */ > > + uint8_t type; > > +/* NB. This enumeration precisely matches hvm.h:X86_EVENTTYPE_* */ > > +# define DMOP_TRAP_ext_int 0 /* external interrupt */ > > +# define DMOP_TRAP_nmi 2 /* nmi */ > > +# define DMOP_TRAP_hw_exc 3 /* hardware exception */ > > +# define DMOP_TRAP_sw_int 4 /* software interrupt (CD nn) */ > > +# define DMOP_TRAP_pri_sw_exc 5 /* ICEBP (F1) */ > > +# define DMOP_TRAP_sw_exc 6 /* INT3 (CC), INTO (CE) */ > > XEN_ prefixes missing. (Did I overlook any in earlier patches? Please > double check.) >
I should have noticed anyway... I'll fix them up. > > + /* IN - enstruction length */ > > + uint8_t insn_len; > > + uint8_t pad; > > + /* IN - error code (or ~0 to skip) */ > > + uint32_t error_code; > > + /* IN - CR2 for page faults */ > > + uint64_aligned_t cr2; > > Another 32-bit padding field is needed ahead of this one. So, it is... I obviously can't count. > > With both taken care of, hypervisor parts > Reviewed-by: Jan Beulich <jbeul...@suse.com> > Thanks, Paul > Jan > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
