Hi,

On Sat, Dec 17, 2016 at 7:16 AM, Dario Faggioli <dario.faggi...@citrix.com>
wrote:

> On Sat, 2016-12-17 at 00:53 +0530, Praveen Kumar wrote:
> > The patch gets rid of a redundant check in csched_vcpu_acct. In fact,
> > the function is only called from csched_tick, which already checks
> > that current is not the idle vcpu. The patch also adds an ASSERT to
> > the same effect, in order to make assumption ( i.e., no calling this
> > on idle vcpus) even more clear and as a guard for future mis-use.
> >
> > Signed-off-by: Praveen Kumar <kpraveen.l...@gmail.com>
> > Acked-by: Dario Faggioli <dario.faggi...@citrix.com>
> >
> Better than before. But still, if I:
>  - save this mail as mbox
>  - try to import it in git
> it fails.
>
> OTOH, if I:
>  - save this mail as mbox
>  - run dos2unix on the mbox file
>  - try to import it in git
> it works!
>
> Which, since you're now using git-send-email, makes me think it may be
> your editor/OS which is at fault and inserts spurious stuff at line
> breaks (the classic CR vs. CR+LF thing).
>
> What editor on what OS are you using?
>

I am using SLED machine and vim editor. I tried checking with vimdiff over
the patch generated and mbox file ( create by evolution ), I found spurious
stuff (^M) as mentioned added. After dos2unix, the mbox file was same to
that of the patch sent.

>
> Another possibility is that there is something wrong here at my hand.
> George, do you have (similar) issues when trying to apply this patch?
>
> Regards,
> Dario
> --
> <<This happens because I choose it to happen!>> (Raistlin Majere)
> -----------------------------------------------------------------
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Reply via email to