On Fri, Jan 06, 2017 at 10:43:59PM +0200, Andy Shevchenko wrote: > On Fri, Jan 6, 2017 at 10:00 PM, Luis R. Rodriguez <mcg...@kernel.org> wrote: > > On Wed, Jan 04, 2017 at 11:47:14AM +0200, Andy Shevchenko wrote: > >> On Tue, Jan 3, 2017 at 11:25 PM, Luis R. Rodriguez <mcg...@kernel.org> > >> wrote: > >> > On Thu, Dec 22, 2016 at 03:58:18PM +0200, Andy Shevchenko wrote: > >> >> On Wed, 2016-12-21 at 18:38 -0800, Luis R. Rodriguez wrote: > >> >> > +#define LINKTABLE_FOR_EACH(pointer, tbl) > >> >> > >> >> Hmm... SOMEONE LIKES CAPITAL LETTERS FOR everything, right? :-) > >> >> > >> >> I would expect more standard linktable_for_each() macro > >> > > >> > hpa had recommended this, if he prefers a lower case I can change that > >> > >> > >> > but I really do consider this bikeshedding. > >> > >> I don't think so: > >> $ git grep -n FOR_EACH | wc -l > >> 83 > >> $ git grep -n for_each | wc -l > >> 23317 > > > > OK, would you also prefer if LINKTABLE_RUN_ERR() and LINKTABLE_RUN_ALL() > > were lowercase ? Or is that fine ? To be clear I'll leave upper case the > > declarers and defines. > > My understanding that macros to run code -- lower case, definitions -- > upper case. > > Thus, *_run_*() macros to lower.
Very well, I've changed these, and since there were users I had to change a bit of the other patches so will send a v6 series follow up. Luis _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel