> -----Original Message----- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 January 2017 11:51 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: Andrew Cooper <andrew.coop...@citrix.com>; Ian Jackson > <ian.jack...@citrix.com>; xen-de...@lists.xenproject.org; Daniel De Graaf > <dgde...@tycho.nsa.gov> > Subject: Re: [PATCH v3 5/8] dm_op: convert HVMOP_modified_memory > > >>> On 12.01.17 at 15:58, <paul.durr...@citrix.com> wrote: > > v3: > > - Addressed more comments from Jan. > > I'd have hoped you would extend these earlier comments to other > applicable places, i.e. for this patch ... > > > +static int modified_memory(struct domain *d, xen_pfn_t *first_pfn, > > + unsigned int *nr) > > +{ > > + xen_pfn_t last_pfn = *first_pfn + *nr - 1; > > + unsigned int iter; > > + int rc; > > + > > + if ( (*first_pfn > last_pfn) || > > + (last_pfn > domain_get_maximum_gpfn(d)) ) > > + return -EINVAL; > > + > > + if ( !paging_mode_log_dirty(d) ) > > + return 0; > > + > > + iter = 0; > > + rc = 0; > > ... here (these would again better be initializers of the respective > variables). But anyway, hypervisor parts > Reviewed-by: Jan Beulich <jbeul...@suse.com> >
Ok, I can make the change in v4... just waiting for Andrew's latest opinion on patch #1. Paul > Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
