On 28/01/17 01:42, Dario Faggioli wrote: > Commit 7478ebe1602e6 ("xen: credit2: fix shutdown/suspend > when playing with cpupools"), while doing the right thing > for actual code, forgot to update the ASSERT()s accordingly, > in csched2_vcpu_migrate(). > > In fact, as stated there already, during shutdown/suspend, > we must allow a Credit2 vCPU to temporarily migrate to a > non Credit2 BSP, without any ASSERT() triggering. > > Move them down, after the check for whether or not we are > shutting down, where the assumption that the pCPU must be > valid Credit2 ones, is valid. > > Signed-off-by: Dario Faggioli <dario.faggi...@citrix.com> > --- > Cc: George Dunlap <george.dun...@eu.citrix.com> > Cc: Anshul Makkar <anshul.mak...@citrix.com> > Cc: Jan Beulich <jbeul...@suse.com> > --- > If 7478ebe1602e is backported, this one should be as well. > > Sorry for this. I'm sure I tested, so I don't know how it could happened... I > must have forgotten debug=n when testing this case. :-(
Indeed, and sorry I missed this on review as well. Reviewed-by: George Dunlap <george.dun...@citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel