On Wed, Feb 22, 2017 at 01:27:34PM +0000, Paul Durrant wrote: > Checking the value of xch->xcall is clearly incorrect. The code should be > checking xch->fmem (i.e. the return of the previously called function). > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com>
Acked-by: Wei Liu <wei.l...@citrix.com> Ian, please backport this. > --- > Cc: Ian Jackson <ian.jack...@eu.citrix.com> > Cc: Wei Liu <wei.l...@citrix.com> > --- > tools/libxc/xc_private.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tools/libxc/xc_private.c b/tools/libxc/xc_private.c > index f0e089c..9df6925 100644 > --- a/tools/libxc/xc_private.c > +++ b/tools/libxc/xc_private.c > @@ -64,8 +64,7 @@ struct xc_interface_core > *xc_interface_open(xentoollog_logger *logger, > goto err; > > xch->fmem = xenforeignmemory_open(xch->error_handler, 0); > - > - if ( xch->xcall == NULL ) > + if ( xch->fmem == NULL ) > goto err; > > return xch; > -- > 2.1.4 > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
