>>> On 27.11.17 at 19:08, <andrew.coop...@citrix.com> wrote: > On 27/11/17 17:01, Jan Beulich wrote: >>>>> On 26.10.17 at 19:03, <euan.har...@citrix.com> wrote: >>> + return X86EMUL_OKAY; >> This and ... >> >>> + } >>> + else >>> + { >>> + pagefault_info_t pfinfo; >>> + int rc = hvm_copy_from_guest_linear(buf, op->mem, bytes, 0, >>> &pfinfo); >>> + >>> + if ( rc == HVMTRANS_bad_linear_to_gfn ) >>> + hvm_inject_page_fault(pfinfo.ec, pfinfo.linear); >>> + if ( rc != HVMTRANS_okay ) >>> + return X86EMUL_EXCEPTION; >>> + >>> + return X86EMUL_OKAY; >> ... this should become a uniform ... >> >>> + } >> ... return here. > > I tried this, but later patches in the series need them to move back. > Overall, this layout reduces the code churn across the series.
Ah, I see. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel