>>> On 06.12.17 at 17:40, <[email protected]> wrote: > On 06/12/17 16:21, Jan Beulich wrote: >> There's no need for >> - advancing the handles and at the same time using >> __copy_{from,to}_guest_offset(), >> - an "out" label, >> - local variables "done" and (function scope) "rc". >> >> Signed-off-by: Jan Beulich <[email protected]> > > These changes do mean that start is no longer ideally named. How about > s/start/extent/, which also matches up better with the parameter name > passed in by its caller?
I did think about it, but then decided that it's still the start of what is yet to be done. But I can do the renaming if you indeed think that's better; it'll only marginally increase page size afaict. Jan _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
