On 15/01/18 10:28, Jan Beulich wrote: >> ctxt->io_emul_stub[10] = 0xff; >> ctxt->io_emul_stub[11] = 0xd1; >> >> + /* >> + * 3 bytes of P6_NOPS. >> + * TODO: untangle ideal_nops from init/livepatch Kconfig options. >> + */ >> + memcpy(&ctxt->io_emul_stub[12], "\x0f\x1f\x00", 3); > Perhaps better "P6_NOP3" in the comment? And perhaps > __stringify(P6_NOP3) in the memcpy() invocation, which may then > make unnecessary that part of the comment?
__stringify(P6_NOP3) really doesn't do what you expect here. This is the preprocessed result: __builtin_memcpy(&ctxt->io_emul_stub[12], "0x0f,0x1f,0x00", 3); I've fixed up the other points, but left this one opencoded. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel