On Thu, Jan 18, 2018 at 06:30:05PM +0000, Andrew Cooper wrote: > On 18/01/18 18:28, Wei Liu wrote: > > On Thu, Jan 18, 2018 at 06:26:02PM +0000, Andrew Cooper wrote: > >> On 18/01/18 18:16, Wei Liu wrote: > >>> To avoid having it changed every time the shim is built. > >>> > >>> Signed-off-by: Wei Liu <[email protected]> > >> One downside of having a this config in-tree is that it needs > >> regenerating every time the Kconfig logic changes. > >> > >> OTOH, I did deliberately wire up all the config options, so > >> > >> make -C tools/firmware/xen-dir shim-olddefconfig > >> > >> or shim-menuconfig etc do work as expected. > >> > >> Do we know why this line is disappearing? I presume it is some change > >> in the Kconfig logic, but I can't spot which changeset. > > I guess that's due to "xen/x86: make VGA support selectable". > > > > The shim.config probably is generated before that patch. > > Can you identify that in the commit message? With that, Reviewed-by: > Andrew Cooper <[email protected]>
AFAICT this is because the Kconfig option for VGA contains: bool "VGA support" if !PV_SHIM_EXCLUSIVE So if PV_SHIM_EXCLUSIVE is selected this option is not even available. With that fixed in the commit message: Reviewed-by: Roger Pau Monné <[email protected]> Although possibly having to change this file every time there's a Kconfig change seems very annoying (and easy to miss). Thanks, Roger. _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
