>>> On 24.01.18 at 15:11, <andrew.coop...@citrix.com> wrote:
> The use of __LINE__ in printk()'s is problematic for livepatching, as it tends
> to cause unnecessary binary differences.
>
> Take this opportunity to provide some rather more useful information than just
> file/line/func in the form of the full register/stack trace leading to the
> problem (which I've needed in the past for debugging).
>
> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
Reviewed-by: Jan Beulich <jbeul...@suse.com>
> --- a/xen/drivers/passthrough/vtd/dmar.h
> +++ b/xen/drivers/passthrough/vtd/dmar.h
> @@ -117,8 +117,10 @@ do { \
> break; \
> if ( NOW() > start_time + DMAR_OPERATION_TIMEOUT ) { \
> if ( !kexecing ) \
> - panic("%s:%d:%s: DMAR hardware is malfunctional",\
> - __FILE__, __LINE__, __func__); \
> + { \
> + dump_execution_state(); \
> + panic("DMAR hardware malfunction"); \
> + } \
> else \
> break; \
Perhaps a good opportunity to take out the pointless "else" as well?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
