>>> On 20.02.18 at 12:01, <roger....@citrix.com> wrote: > --- a/xen/include/asm-x86/asm_defns.h > +++ b/xen/include/asm-x86/asm_defns.h > @@ -15,6 +15,9 @@ > #include <asm/alternative.h> > > #ifdef __ASSEMBLY__ > +#ifndef CONFIG_INDIRECT_THUNK > +.equ CONFIG_INDIRECT_THUNK, 0 > +#endif > # include <asm/indirect_thunk_asm.h> > #else > asm ( "\t.equ CONFIG_INDIRECT_THUNK, " > > It's fairly similar to my first approach, but at least "#ifdef > CONFIG_INDIRECT_THUNK" will still work as expected after this fix.
I've used something similar in backports to old versions, so I wonder whether what you quote above is right: Assembly files don't get handed to clang anyway iirc, so the change would seem to be needed in the #else part of the conditional. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
