>>> On 22.02.18 at 19:44, <wei.l...@citrix.com> wrote: > On Wed, Dec 06, 2017 at 03:50:10PM +0800, Chao Gao wrote: >> + " mov $lock,%edx \n" > > Not really an expert in x86 asm -- shouldn't this be lea instead?
No, when MOV can be used it's preferable as having a 1 byte shorter encoding. There are a few cases where MOV may not be appropriate, but I don't think the one here is. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel