On Wed, Feb 07, 2018 at 08:04:10PM -0700, Jim Fehlig wrote:
> Applications like libvirt may not populate a device devid field,
> delegating that to libxl. If needed, the application can later
> retrieve the libxl-produced devid. Indeed most devices are handled
> this way in libvirt, channel devices included.
> This works well when only one channel device is defined, but more
> than one results in
> qemu-system-i386: -chardev socket,id=libxl-channel-1,\
> Duplicate ID 'libxl-channel-1' for chardev
> Besides the odd '-1' value in the id, multiple channels have the same
> id, causing qemu to fail. A simple fix is to set an uninitialized
> devid (-1) to the dev_num passed to libxl__init_console_from_channel().
> Signed-off-by: Jim Fehlig <jfeh...@suse.com>
> I get the feeling that if needed devid should be set earlier, but
> this seems like the most opportune spot. Suggestions for improvements
I think this approach is fine.
Xen-devel mailing list