On 03/09/2018 04:25 PM, Jan Beulich wrote: >>>> On 09.03.18 at 17:17, <o...@aepfle.de> wrote: >> --- a/xen/include/public/domctl.h >> +++ b/xen/include/public/domctl.h >> @@ -137,6 +137,8 @@ DEFINE_XEN_GUEST_HANDLE(xen_domctl_getdomaininfo_t); >> #define XEN_DOMCTL_PFINFO_BROKEN (0xdU<<28) /* broken page */ >> #define XEN_DOMCTL_PFINFO_LTAB_MASK (0xfU<<28) >> >> +#define XEN_GETPAGEFRAMEINFO3_MAX_SIZE 1024U > > This is an implementation detail; it shouldn't be made part of the > public interface. If there's a need for user land to know the value, > and if there's currently no way to query it, that's what you > would want to add.
But the domctl interface isn't stable, right? There's no need to make a flexible backwards-compatible interface between libxc and Xen; sharing a #define should be fine, as long as there's only one place to change it. -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
