Hi George,

On 03/15/2018 04:15 PM, George Dunlap wrote:
On Wed, Mar 14, 2018 at 6:19 PM,  <julien.gr...@arm.com> wrote:
From: Julien Grall <julien.gr...@arm.com>

The construction _gfn(paddr_to_pfn(...)) can be simplified by using
gaddr_to_gfn.

Signed-off-by: Julien Grall <julien.gr...@arm.com>

Not sure if "simplified" is the right word here (and in the previous
patch); simplified implies fewer steps in the calculation, but it
looks like the steps so far are identical.  Using a macro rather than
hand-coding stuff is cleaner and more maintainable; don't think it
really needs to be justified.

I can drop the justification in both patches.


In any case:

Reviewed-by: George Dunlap <george.dun...@citrix.com>

Thank you!

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to