On Thu, Jul 01, 2021 at 11:56:28AM +0200, Olaf Hering wrote:
> This will help libxl_save_msgs_gen.pl to copy the struct as a region of
> memory.
>
> No change in behavior intented.
>
> Signed-off-by: Olaf Hering <o...@aepfle.de>
> ---
> tools/include/xensaverestore.h | 7 +++----
> tools/libs/saverestore/common.h | 2 +-
> tools/libs/saverestore/save.c | 6 +++---
> 3 files changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/tools/include/xensaverestore.h b/tools/include/xensaverestore.h
> index 0410f0469e..dca0134605 100644
> --- a/tools/include/xensaverestore.h
> +++ b/tools/include/xensaverestore.h
> @@ -23,18 +23,17 @@
> #define XCFLAGS_DEBUG (1 << 1)
>
> /* For save's precopy_policy(). */
> -struct precopy_stats
I don't think changing the existing API is a good idea. It's probably ok
to add a typedef. But can't libxl_save_msgs_gen.pl been able to deal with
thing like 'struct precopy_stats' ? It seems to be able to deal with
'unsigned long'.
> -{
> +typedef struct {
> unsigned int iteration;
> unsigned long total_written;
> long dirty_count; /* -1 if unknown */
> -};
> +} precopy_stats_t;
>
Thanks,
--
Anthony PERARD
