> On Jul 14, 2021, at 5:17 PM, Anthony PERARD <anthony.per...@citrix.com> wrote: > > This will help prevent the CI loop from having build failures when > `checkpolicy` isn't available, when doing "randconfig" jobs.
Hang on, just to clarify what’s going on here. ‘randconfig’ is setting CONFIG_XSM_FLASK_POLICY in the .config file; and then when the build happens, we error out because one of the required components isn’t there. What this patch does is to make it so that if someone explicitly sets CONFIG_XSM_FLASK_POLICY=y, but doesn’t have checkpolicy, the build system will silently disable the policy behind their backs without telling them? Or does the randconfig test run kConfig one more time, at which point *then* the .config will be disabled? The former I think is broken; the latter I think is fine. -George
