On 01.07.2021 16:10, Anthony PERARD wrote: > Those two dependencies already exist so make doesn't need to know > about them. The dependency will be generated by $(CC). > > Signed-off-by: Anthony PERARD <anthony.per...@citrix.com>
Unless I'm mistaken this was actually an omission by 68b1230ae393 ("Auto-build dependency files in hypervisor build tree"), which would again suggest this can go in independently of all of the earlier patches? In any event Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan > --- a/xen/arch/x86/Makefile > +++ b/xen/arch/x86/Makefile > @@ -84,7 +84,6 @@ extra-y += xen.lds > ifneq ($(CONFIG_HVM),y) > x86_emulate.o: CFLAGS-y += -Wno-unused-label > endif > -x86_emulate.o: x86_emulate/x86_emulate.c x86_emulate/x86_emulate.h > > efi-y := $(shell if [ ! -r $(BASEDIR)/include/xen/compile.h -o \ > -O $(BASEDIR)/include/xen/compile.h ]; then \ >