On 13.08.2021 14:27, Julien Grall wrote: > On 28/07/2021 11:27, Penny Zheng wrote: >> --- a/xen/include/xen/mm.h >> +++ b/xen/include/xen/mm.h >> @@ -132,6 +132,12 @@ int query_page_offline(mfn_t mfn, uint32_t *status); >> void heap_init_late(void); >> >> int assign_pages( >> + struct page_info *pg, >> + unsigned long nr, >> + struct domain *d, >> + unsigned int memflags); >> + >> +int assign_page( >> struct domain *d, >> struct page_info *pg, >> unsigned int order, > > I find a bit odd that the parameters are ordered differently between > assign_pages() and assign_page(). They are similar interface after all. > > I don't think it would be a problem for backporting purpose if > assign_page() has a different order for the arguments. > > Jan, what do you think?
Having both functions with similar parameter arrangement would certainly seem better to me, too. Jan
