On 16/08/2021 16:30, Jan Beulich wrote:
> Especially with XEN_GUEST, being a prereq of PV_SHIM, defaulting to N,
> v{xenstore,console}_{start,end} can only ever be zero in such default
> configurations. And in case video is the only output configured, space
> is scarce. Omit the two lines carrying no information at all in this
> case.
>
> Signed-off-by: Jan Beulich <[email protected]>Acked-by: Andrew Cooper <[email protected]> as this is an improvement, but honestly I think it would be better done differently. Each line ought be a separate printk() in the first place, and these two messages should be conditional on opt_pv_shim rather than CONFIG_PV_SHIM. That will also shrink the output for native boot when SHIM is enabled. It also lets you conditionally drop the ramdisk line which has some conditional printing a few lines earlier for the physical layout, but unconditional printing for the virtual layout. And on that note, the earlier few printk()'s really need some newline corrections. If you do go with this approach, feel free to retain my Ack. ~Andrew
