Hi Jan > On 20 Aug 2021, at 8:06 am, Jan Beulich <[email protected]> wrote: > > On 19.08.2021 14:02, Rahul Singh wrote: >> Compilation error is observed when ACPI and HAS_PCI is enabled for ARM >> architecture. Move the code under CONFIG_X86 flag to gate the code for >> ARM. > > Please give at least one example of what it is that fails to compile. > What an appropriate action is depends on the nature of the error(s), > and from looking at the enclosed code I cannot easily see what it > might be that breaks for Arm.
I am observing below error when enabled ACPI && HAS_PCI for ARM. prelink.o: In function `pcie_aer_get_firmware_first’: /xen/drivers/passthrough/pci.c:1251: undefined reference to `apei_hest_parse' aarch64-linux-gnu-ld: /home/rahsin01/work/xen/pci-passthrough-upstream/xen/xen/.xen-syms.0: hidden symbol `apei_hest_parse' isn't defined I found that apei/ is only enabled for x86 and pcie_aer_get_firmware_first() is only called from x86 code. obj-$(CONFIG_X86) += apei/ I am not sure whether we need this code for ARM architecture that is why I gate the code for ARM via CONFIG_X86 > > And as suggested by Julien for the earlier patch - you will want to > re-order things such that compilation doesn't "break" in the first > place. Title and description would then want adjusting accordingly. Let me reorder the patch series in next version. Regards, Rahul > > Jan >
