Hi Jan, Julien, > -----Original Message----- > From: Jan Beulich <[email protected]> > Sent: 2021年8月25日 21:36 > To: Julien Grall <[email protected]>; Wei Chen <[email protected]> > Cc: Bertrand Marquis <[email protected]>; xen- > [email protected]; [email protected] > Subject: Re: [XEN RFC PATCH 14/40] xen/arm: set NUMA nodes max number to > 64 by default > > On 25.08.2021 15:28, Julien Grall wrote: > > On 11/08/2021 11:23, Wei Chen wrote: > >> --- a/xen/include/asm-arm/numa.h > >> +++ b/xen/include/asm-arm/numa.h > >> @@ -5,7 +5,15 @@ > >> > >> typedef u8 nodeid_t; > >> > >> -#if !defined(CONFIG_NUMA) > >> +#if defined(CONFIG_NUMA) > >> + > >> +/* > >> + * Same as x86, we set the max number of NUMA nodes to 64 and > >> + * set the number of NUMA memory block number to 128. > >> + */ > > > > Such comment can rot easily if x86 decides to bump there values. But > > given the value is the same, I think it would make sense to move the > > define to xen/numa.h. > > To be honest - if this gets moved, please at least consider making it > a proper Kconfig setting. Just as much a the number of CPUs can be > configured, the number of nodes should be possible to choose by the > build manager. Of course - if it's not too much trouble ... >
Ok > Jan
