Re: [PATCH] libs/light: fix tv_sec fprintf format

[Juergen Gross]

On 28.08.21 11:07, Fabrice Fontaine wrote:

Don't assume tv_sec is a unsigned long, it is 64 bits on NetBSD 32 bits.
Use %jd and cast to (intmax_t) instead

Signed-off-by: Fabrice Fontaine <fontaine.fabr...@gmail.com>
---
  tools/libs/light/libxl_domain.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libs/light/libxl_domain.c b/tools/libs/light/libxl_domain.c
index c00c36c928..51a6127552 100644
--- a/tools/libs/light/libxl_domain.c
+++ b/tools/libs/light/libxl_domain.c
@@ -1444,7 +1444,7 @@ static int libxl__mark_domid_recent(libxl__gc *gc, 
uint32_t domid)
          }
      }

+    r = fprintf(nf, "%jd %u\n", (intmax_t)ctxt.ts.tv_sec, domid);

- r = fprintf(nf, "%lu %u\n", ctxt.ts.tv_sec, domid);

Any reason not to keep the unsigned attribute?


Juergen

OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

OpenPGP_signature
Description: OpenPGP digital signature