On 26/08/2021 11:09, Jan Beulich wrote: > By default all guests are permitted to have up to 1024 maptrack frames, > which on 64-bit means an 8k frame table. Yet except for driver domains > guests normally don't make use of grant mappings. Defer allocating the > table until a map track handle is first requested. > > Signed-off-by: Jan Beulich <jbeul...@suse.com>
Nack. This creates new dynamic failures outside the VM's control, therefore regressing Xen's usability. The maptrack array (and frames for that matter) should be allocated at domain creation time, like we do for most other structures in the hypervisor. Furthermore, seeing as this has come up on multiple community calls, I will remind you that it is not just Citrix as a downstream which is firmly of this opinion. This entire patch should be replaced with one that... > --- > I continue to be unconvinced that it is a good idea to allow all DomU-s > 1024 maptrack frames by default. ... defaults to something smaller for plain domUs, because this improves the general case without leaving VMs more liable to crash at runtime. ~Andrew
