On 9/9/21 11:35 AM, Jan Beulich wrote: > On 03.09.2021 21:06, Daniel P. Smith wrote: >> The internal define flag is not used by any XSM module, removing the #ifdef >> leaving the generic event channel labeling as always present. > > Already on v2 I did ask > > "I'm not fully convinced of this removal: Does it get in the way of > anything?" > > I have no record of getting reply, so I'm still wondering.
I can't find any email record of it but I know I made this change because of a request to drop XSM_NEED_GENERIC_EVTCHN_SSID since it is completely unused. Honestly I am not concerned on whether this completely unused field is kept or not that is behind a flag that is never set but it clearly is concerning for you, so I will just drop this for now. v/r, dps
