On 15/09/2021 10:30, Jan Beulich wrote: > On 14.09.2021 18:43, Kevin Stefanov wrote: >> --- a/tools/libs/light/libxl_x86_acpi.c >> +++ b/tools/libs/light/libxl_x86_acpi.c >> @@ -20,6 +20,7 @@ >> >> /* Number of pages holding ACPI tables */ >> #define NUM_ACPI_PAGES 16 >> +#define ALIGN(p, a) (((p) + ((a) - 1)) & ~((a) - 1)) > Wouldn't this better live in xen-tools/libs.h?
In this case, not really. That file doesn't exist on all versions this bugfix needs backporting to, and there is an unknown chance of collision in older trees. This would be a whole lot easier if ROUNDUP() wasn't in a dubious state... ~Andrew
