On 10.09.2021 20:18, Oleksandr Tyshchenko wrote:
> --- a/tools/include/libxl.h
> +++ b/tools/include/libxl.h
> @@ -855,6 +855,13 @@ typedef struct libxl__ctx libxl_ctx;
> */
> #define LIBXL_HAVE_PHYSINFO_MAX_POSSIBLE_MFN 1
>
> + /*
> + * LIBXL_HAVE_PHYSINFO_GPADDR_BITS
> + *
> + * If this is defined, libxl_physinfo has a "gpaddr_bits" field.
> + */
> + #define LIBXL_HAVE_PHYSINFO_GPADDR_BITS 1
Nit: I don't think you mean to have leading blanks here?
> @@ -120,6 +120,7 @@ struct xen_sysctl_physinfo {
> uint64_aligned_t outstanding_pages;
> uint64_aligned_t max_mfn; /* Largest possible MFN on this host */
> uint32_t hw_cap[8];
> + uint32_t gpaddr_bits;
> };
Please make trailing padding explicit. I wonder whether this needs
to be a 32-bit field: I expect we would need a full new ABI by the
time we might reach 256 address bits. Otoh e.g. threads_per_core is
pretty certainly oversized as well ...
Jan
