Hi Julien > On 23 Sep 2021, at 3:07 am, Julien Grall <julien.grall....@gmail.com> wrote: > > Hi, > > On Wed, 22 Sep 2021, 16:36 Rahul Singh, <rahul.si...@arm.com> wrote: > Compilation error is observed when HAS_PCI is enabled for ARM > architecture. > > In general, when I read "compilation error" I interpret as a user can trigger > it in the current staging. > > However, without the full series applied, HAS_PCI cannot be selected on Arm. > > So I think the message is a bit misleading because this is more implementing > stubs to enable a feature rather than fixing compilation errors (AFAICT all > of them are not fixed here). > > How about the following commit message: > > xen/arm: pci: Add stubs to allow selecting HAS_PCI > > In a follow-up we will enable PCI support in Xen on Arm (i.e select HAS_PCI). > > The generic code expects the arch to implement a few functions: > > <List the functions> > > Note that this is not yet sufficient to enable HAS_PCI and will be addressed > in follow-ups. >
Ok. I will modify the commit message in next version. Regards, Rahul
