On Thu, Sep 23, 2021 at 01:27:30PM +0200, Jan Beulich wrote: > On 23.09.2021 10:23, Roger Pau Monné wrote: > > On Tue, Sep 21, 2021 at 09:20:32AM +0200, Jan Beulich wrote: > >> There's not really any register state associated with offline vCPU-s, so > >> avoid spamming the log with largely useless information while still > >> leaving an indication of the fact. > >> > >> Signed-off-by: Jan Beulich <[email protected]> > > > > Reviewed-by: Roger Pau Monné <[email protected]> > > Thanks. > > > Is the state cleared when the vCPU is brought down? Or else it might > > be interesting to print such state for debug purposes. > > Hmm, if that's considered to be potentially useful, then we'd need a > key different from VPF_down. HLT would leave state in place, and the > INIT/SIPI sequence would clobber prior state also only on the 2nd > step. v->is_initialised may be an option, but gets cleared by INIT, > not SIPI. Any other ideas?
Well, I guess it's close enough. I also wonder whether we should do something similar for PV, where it might even make more sense as you can upload a vCPU state in that case when the vCPU is down. Thanks, Roger.
